https://bugzilla.redhat.com/show_bug.cgi?id=1884943 --- Comment #4 from Christoph Junghans <junghans@xxxxxxxxx> --- (In reply to Susi Lehtola from comment #2) > APPROVED by jussilehtola Thanks. > [!]: License file installed when any subpackage combination is installed. Fixed. > [!]: Changelog in prescribed format. > > Changelog is not in predescribed format. Also the comment is wrong: this is > not the initial import (which would be the git commit message for import), > but the initial version of the packaging! Fixed > [!]: Package consistently uses macros (instead of hard-coded directory > names). > > This is an aesthetic issue, but the use of curly brackets is inconsistent: > %build > %{cmake} > %cmake_build Fixed > [!]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in > libecpint-common > > As noted above, add this. Hmm, libecpint depends on libecpint-common not the other way around, so I am not 100% sure here > [!]: Spec file according to URL is the same as in SRPM. > Note: Spec file as given by url is not the same as in SRPM (see > attached diff). > See: (this test has no URL) My mistake, will be same. > libecpint-devel.x86_64: W: description-shorter-than-summary Fixed > libecpint-debugsource.x86_64: W: invalid-url URL: > https://github.com/robashaw/libecpint <urlopen error [Errno -3] Temporary The url works, so not sure, but I have seen that before -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
