https://bugzilla.redhat.com/show_bug.cgi?id=1872427 --- Comment #9 from Carl George 🤠 <carl@xxxxxxxxxx> --- The latest spec file still has conditionals for another distribution, which is explicitly prohibited by policy [0]. > To help facilitate legibility, only macros and conditionals for Fedora and EPEL are allowed to be used in Fedora Packages. Once the source location has been "approved" (I'm assuming this means a git tag in that GitHub repo), make sure to use the recommended format for GitHub git tags [1]. The %setup invocation is wrong. %{name}-%{version} is the argument for the -n flag that I mentioned should be removed. If the top level directory in the source tarball matches %{name}-%{version}, the invocation should be just `%setup -q`. [0] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_spec_legibility [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
