[Bug 1872427] Review Request: ec2-hibinit-agent - support for hibernation for Amazon ec2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1872427



--- Comment #7 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> ---
%global debug_package %{nil}

Suspicious, it needs to be justified' why can't you generate debuginfo

 - 2 times systemd-rpm-macros which should be a BuildRequires not a Requires:

BuildRequires: systemd-rpm-macros 
BuildRequires: python3-devel
Requires: acpid 
Requires: grubby
Requires: tuned

 - I don't particully mind %if 0%{?amzn}, I asked once about suse directive and
I was said it was ok.



 - Have a look at the SELINUX macros at
/usr/lib/rpm/macros.d/macros.selinux-policy
There are some macros you should use:

%selinux_requires

# %selinux_modules_install [-s <policytype>] [-p <modulepriority>] module
[module]...
%selinux_modules_install("s:p:")

# %selinux_modules_uninstall [-s <policytype>] [-p <modulepriority>] module
[module]...
%selinux_modules_uninstall("s:p:") \


# %selinux_relabel_pre [-s <policytype>]
%selinux_relabel_pre("s:") \

# %selinux_relabel_post [-s <policytype>]
%selinux_relabel_post("s:") \


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux