https://bugzilla.redhat.com/show_bug.cgi?id=1877006 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx Flags| |fedora-review? --- Comment #3 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- > - Source must either be an url or you need to add a comment explaining how > the archive got generated: > > Source0: %{name}-%{version}.tar.gz Hmm ... if I put the line: Source0: https://github.com/jcbf/smf-spf/archive/v2.4.3.tar.gz then I get the following message: # rpmbuild -ba smf-spf.spec error: Bad source: /root/rpmbuild/SOURCES/v2.4.3.tar.gz: No such file or directory How/where should I include the URL? First Source0: https://github.com/jcbf/smf-spf/archive/v%{version}/%{name}-%{version}.tar.gz Then you should d/l with: spectool -g smf-spf.spec It will d/l the source next to your SPEC. Secondly, I never use rpmbuild anymore. I always use a chroot: fedpkg --release f34 mockbuild --mock-config fedora-rawhide-x86_64 This avoid mixing the deps with your own system, and maybe miss deps. Then you can check your build on Koji afterwards: fedpkg --release f34 scratch-build --srpm --fail-fast >> - make %{?_smp_mflags} OPTFLAGS="%{optflags}" >> >> → >> >> %set_build_flags >Sorry, I don't understand this. See your patch: diff -ru smf-spf-2.4.3.orig/Makefile smf-spf-2.4.3/Makefile --- smf-spf-2.4.3.orig/Makefile 2020-03-26 00:45:26.000000000 +0100 +++ smf-spf-2.4.3/Makefile 2020-06-15 11:03:57.339000000 +0200 @@ -7,10 +7,10 @@ CONFDIR = /etc/mail/smfs USER = smfs GROUP = smfs -CFLAGS = -O2 -D_REENTRANT -fomit-frame-pointer -I/usr/local/include +CFLAGS = -pthread $(OPTFLAGS) # Linux -LDFLAGS = -lmilter -lpthread -L/usr/lib/libmilter -L/usr/local/lib -lspf2 +LDFLAGS = -lmilter -lpthread -lspf2 # FreeBSD #LDFLAGS = -lmilter -pthread -L/usr/local/lib -lspf2 @@ -25,7 +25,6 @@ smf-spf: smf-spf.o $(CC) -o smf-spf smf-spf.o $(LDFLAGS) - strip smf-spf smf-spf.o: smf-spf.c $(CC) $(CFLAGS) -c smf-spf.c I don't think it is judicious to use $(OPTFLAGS) here, instead you can use the macro %set_build_flags to define CFLAGS and LDFLAGS at the same time to use with make afterwards: %set_build_flags %make_build >> - Explicitly BR gcc >I don't understand this. For C and C++ programs, you must explicitly BuildRequires the compiler BuildRequires: gcc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
