https://bugzilla.redhat.com/show_bug.cgi?id=1884598 --- Comment #3 from Jonny Heggheim <hegjon@xxxxxxxxx> --- (In reply to Andy Mender from comment #2) > I see fedora-review struggled with resolving %{forgesource}, but since it > worked in Koji, everything's in order. > > Package approved. Full review below: Thanks for the review. fedora-review spotted an actual problem in %{forgesource}, thanks for pointing it out, it probably saved me a lot of debugging. %forge-macro assume that git-tags/releases have 'v' as a prefix, clitest used nothing as prefix. So adding > %global tag %{version} solved the sourceurl -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
