https://bugzilla.redhat.com/show_bug.cgi?id=1884110 --- Comment #1 from Andy Mender <andymenderunix@xxxxxxxxx> --- Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=52703792 > Summary: Books Organizer > URL: https://github.com/%{owner}/%{name} > Source0: https://github.com/%{owner}/%{name}/archive/%{commit}/%{name}-%{commit}.tar.gz You can use the URL inside Source0 like this to make it simpler: %{url}/archive/%{commit}/%{name}-%{commit}.tar.gz > BuildRequires: gcc-c++ > #BuildRequires: qt5-devel Any reason qt5-devel is commented out? If it's not needed, could you remove it? > # NOTE: It would be *awesome* if this file was maintained by the upstream > # project, translated and installed into the right place during `make install`. Probably a good idea to submit a PR to upstream then :). > mkdir -p $RPM_BUILD_ROOT%{_datadir}/appdata > cat > $RPM_BUILD_ROOT%{_datadir}/appdata/%{name}.appdata.xml <<EOF Please use either $RPM_BUILD_ROOT or %{buildroot}, but not both interchangeably. This is mentioned in the review matrix below as well. > %files > %{_bindir}/%{name} > %{_datadir}/applications/%{name}.desktop > %{_datadir}/icons/hicolor/scalable/apps/%{name}.svg > %{_datadir}/appdata/%{name}.appdata.xml No license file added and I see upstream doesn't have one either in the source tree. Could you please ask upstream to include a license file in their repository? The full review is below: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package uses either %{buildroot} or $RPM_BUILD_ROOT Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. Please add this step to the %install block. More info here: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages Review: Tested in Koji. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GPL (v3)", "GPL (v2 or later)", "GPL (v3.0)". 103 files have unknown license. Detailed output of licensecheck in /home/amender/rpmbuild/SPECS/booksorg/booksorg/licensecheck.txt [!]: License file installed when any subpackage combination is installed. Review: no license file installed. Please add a license file under the %files block with the %license macro. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor, /usr/share/icons/hicolor/scalable Review: likely missing Requires on hicolor-icon-theme [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [?]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [!]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. Review: Tested in Koji. [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: booksorg-0.3.1-1.fc34.x86_64.rpm booksorg-debuginfo-0.3.1-1.fc34.x86_64.rpm booksorg-debugsource-0.3.1-1.fc34.x86_64.rpm booksorg-0.3.1-1.fc33.src.rpm booksorg.x86_64: W: spelling-error %description -l en_US pdf -> PDF, pd, pf booksorg.x86_64: W: spelling-error %description -l en_US sqlite -> sq lite, sq-lite, satellite booksorg.x86_64: E: description-line-too-long C Books Organizer an organizer for pdf files based on sqlite and with a built-in reader. booksorg.x86_64: E: description-line-too-long C Bring your favorite PDF pages all in one! Make your own extract pages from existing ones. booksorg.x86_64: W: no-documentation booksorg.x86_64: E: script-without-shebang /usr/share/icons/hicolor/scalable/apps/booksorg.svg booksorg.x86_64: W: no-manual-page-for-binary booksorg booksorg.src: W: spelling-error %description -l en_US pdf -> PDF, pd, pf booksorg.src: W: spelling-error %description -l en_US sqlite -> sq lite, sq-lite, satellite booksorg.src: E: description-line-too-long C Books Organizer an organizer for pdf files based on sqlite and with a built-in reader. booksorg.src: E: description-line-too-long C Bring your favorite PDF pages all in one! Make your own extract pages from existing ones. Review: The line limit for the %description is 80 characters. Could you please split it into lines accordingly? 4 packages and 0 specfiles checked; 5 errors, 6 warnings. Rpmlint (debuginfo) ------------------- Checking: booksorg-debuginfo-0.3.1-1.fc34.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- (none): E: no installed packages by name booksorg-debugsource (none): E: no installed packages by name booksorg-debuginfo (none): E: no installed packages by name booksorg 0 packages and 0 specfiles checked; 0 errors, 0 warnings. Source checksums ---------------- https://github.com/zakariakov/booksorg/archive/cd3741dad92f703c2346c16abed827ee1d76a8df/booksorg-cd3741dad92f703c2346c16abed827ee1d76a8df.tar.gz : CHECKSUM(SHA256) this package : 39c193157074778f8ea4e5700b758aa6702594d5a1c2ec033b59d1c2d6d76347 CHECKSUM(SHA256) upstream package : 39c193157074778f8ea4e5700b758aa6702594d5a1c2ec033b59d1c2d6d76347 Requires -------- booksorg (rpmlib, GLIBC filtered): libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5DBus.so.5()(64bit) libQt5DBus.so.5(Qt_5)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Sql.so.5()(64bit) libQt5Sql.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libQt5Xml.so.5()(64bit) libQt5Xml.so.5(Qt_5)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libpoppler-qt5.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) qt5-qtbase rtld(GNU_HASH) booksorg-debuginfo (rpmlib, GLIBC filtered): booksorg-debugsource (rpmlib, GLIBC filtered): Provides -------- booksorg: application() application(booksorg.desktop) booksorg booksorg(x86-64) metainfo() metainfo(booksorg.appdata.xml) mimehandler(application/pdf) booksorg-debuginfo: booksorg-debuginfo booksorg-debuginfo(x86-64) debuginfo(build-id) booksorg-debugsource: booksorg-debugsource booksorg-debugsource(x86-64) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
