https://bugzilla.redhat.com/show_bug.cgi?id=1881370 Jaroslav Škarvada <jskarvad@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(jskarvad@redhat.c | |om) | --- Comment #5 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> --- (In reply to aegorenk from comment #4) Thanks for the review. > Notes: > > - [!]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. > > I think it's fine in this case since there is only one source file, which > contains license information. > > - Please pay attention to rpmlint output. > > wwl.x86_64: W: invalid-license Semi-Permissive > should be fine > I am ready to rename the license if the fedora-legal will come up with some different name. > wwl.x86_64: W: spurious-executable-perm /usr/share/man/man1/wwl.1.gz > should be fixed > It should be fixed now. > wwl.x86_64: W: spelling-error %description -l en_US hamradio -> ham radio, > ham-radio, radiogram > should be fine if you think this is the correct way to spell it > Fixed. I took the original description from the upstream, I think "ham radio" is better. > (none): E: no installed packages by name wwl > Not sure about this one. Rather looks like the fedora-review tool problem > than the package itself > Probably. Spec URL: https://jskarvad.fedorapeople.org/wwl/wwl.spec SRPM URL: https://jskarvad.fedorapeople.org/wwl/wwl-1.3-2.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
