https://bugzilla.redhat.com/show_bug.cgi?id=1882871 --- Comment #4 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- >>1. You need to call the %set_build_flags macro to ensure that Fedora's CXXFLAGS are set properly. >Is this necessary? I saw that many other rpm packages do not add this. for example: >https://src.fedoraproject.org/rpms/premake/blob/master/f/premake.spec Fedora's CFLAGS are available in the form of the %{optflags} RPM macro. What %set_build_flags does, is it simply performs 'export CFLAGS="%{optflags}"' (and the same for CXXFLAGS). The linked spec for premake employs a slightly different approach, as it uses sed to inject %{optflags} straight into the Makefile. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
