https://bugzilla.redhat.com/show_bug.cgi?id=1882908 --- Comment #2 from Zamir SUN <sztsian@xxxxxxxxx> --- (In reply to Andy Mender from comment #1) > Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=52316193 > > > License: GPLv2 and LGPLv2 > > Is it clear which parts use which license? If so, could you indicate that in > a comment above the line? They do have SPDX-License-Identifier, but I'm reluctant to add such comment. It's not differ per dir, but rather per file. Maintaining such a comment is kind of wasting time for packaging. > > %install > > libdir=%{_libdir} make libdir=%{_libdir} prefix=%{_prefix} V=1 DESTDIR=%{buildroot}/ CFLAGS="%{optflags} -D_GNU_SOURCE" LDFLAGS="%{build_ldflags} -z muldefs " BUILD_TYPE=Release install_gui > > Why is "libdir" also defined as an environment variable for this command? > That was to workaround a bug before. Just tried now it works without the environment var. Updated in-place. SPEC URL: https://zsun.fedorapeople.org/pub/pkgs/kernelshark/kernelshark.spec SRPM URL: https://zsun.fedorapeople.org/pub/pkgs/kernelshark/kernelshark-1.1-1.fc34.src.rpm Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=52333193 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
