https://bugzilla.redhat.com/show_bug.cgi?id=1882871 Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #2 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- >Source0: https://github.com/xmake-io/xmake/archive/%{xmake_branch}.tar.gz#/xmake-%{xmake_branch}.tar.gz >Source1: https://github.com/tboox/tbox/archive/%{tbox_branch}.tar.gz#/tbox-%{tbox_branch}.tar.gz >Source2: https://github.com/xmake-io/xmake-core-luajit/archive/v%{luajit_branch}.tar.gz#/xmake-core-luajit- Links to a branch point to, well, a branch - which is a moving target. If you re-fetch these links a year from now, the file will be different. You should specify links which will always return the same file. With GitHub, you can reference a git tag, or a specific commit. https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ >License: Apache-2.0 Fedora uses the "ASL 2.0" short identifier for this licence. https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses >%build >make build 1. You need to call the %set_build_flags macro to ensure that Fedora's CXXFLAGS are set properly. 2. Use the %make_build macro. >cp -r xmake %{buildroot}%{_datadir}/%{name} >cp core/src/demo/demo.b %{buildroot}%{_bindir}/%{name} Use "cp -a" or "cp -p" so that file timestamps are preserved. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps >%clean >rm -rf %{buildroot} The %clean section is not used in Fedora. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
