https://bugzilla.redhat.com/show_bug.cgi?id=1880636 --- Comment #22 from Jie Kang <jkang@xxxxxxxxxx> --- (In reply to Miro Hrončok from comment #21) > jmc comments: I've updated the jmc spec and rpm, links are unchanged. Replied to comments in-line below. > > > If a package contains a GUI application, then it SHOULD install a > .appdata.xml file into %{_metainfodir}. Added. > > > macros in comments: > > jmc.src:182: W: macro-in-comment %{_os} > jmc.src:182: W: macro-in-comment %{eclipse_arch} Checked; the comments make sense. > > > Possibly unstripped executable? > > jmc.x86_64: W: unstripped-binary-or-object /usr/lib/jmc/jmc I looked at [1] and am not entirely sure what the expected action is for this warning. Is there an updated document? [1] https://fedoraproject.org/wiki/Common_Rpmlint_issues#unstripped-binary-or-object > > > > Broken symbolic link: > > # ls -l /usr/lib/jmc/plugins/com.sun.mail.jakarta.mail_1.6.5.jar > lrwxrwxrwx. 1 root root 41 Sep 22 10:41 > /usr/lib/jmc/plugins/com.sun.mail.jakarta.mail_1.6.5.jar -> > /usr/share/java/javamail/jakarta.mail.jar > # ls -l /usr/share/java/javamail/jakarta.mail.jar > ls: cannot access '/usr/share/java/javamail/jakarta.mail.jar': No such file > or directory I've changed jmc to use javamail 1.5.2 which is currently in Fedora. jakarta-mail should be backwards compatible to some extent, so will be cleaning or fixing jmc spec when that is available. > > > > Also some files, I don't know where they come from, seem to be packaged with > different license: > > # rpm -ql jmc | grep about_files > /usr/lib/jmc/plugins/org.eclipse.swt.gtk.linux.x86_64_3.114.100.v20200612- > 0706/about_files > /usr/lib/jmc/plugins/org.eclipse.swt.gtk.linux.x86_64_3.114.100.v20200612- > 0706/about_files/IJG_README > /usr/lib/jmc/plugins/org.eclipse.swt.gtk.linux.x86_64_3.114.100.v20200612- > 0706/about_files/lgpl-v21.txt > /usr/lib/jmc/plugins/org.eclipse.swt.gtk.linux.x86_64_3.114.100.v20200612- > 0706/about_files/mpl-v11.txt > /usr/lib/jmc/plugins/org.eclipse.swt.gtk.linux.x86_64_3.114.100.v20200612- > 0706/about_files/mpl-v20.txt > /usr/lib/jmc/plugins/org.eclipse.swt.gtk.linux.x86_64_3.114.100.v20200612- > 0706/about_files/webkit-bsd.txt > > I don't see the files in sources, are they copied from the buildroot? JMC is an Eclipse RCP application so it's underlying platform is the Eclipse platform, the same as the Eclipse IDE. This is part of that Eclipse platform. For licensing, JMC has a THIRDPARTYREADME that lists direct dependencies like Eclipse, but it doesn't do transitives from there. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
