Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: postfix-logwatch - A postfix log analyzer for logwatch Alias: postfix-logwatch https://bugzilla.redhat.com/show_bug.cgi?id=350341 ------- Additional Comments From kevin@xxxxxxxxx 2007-11-03 13:56 EST ------- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPLv2+) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: c5eda596bc3d142ff5cf6db7986e6459 postfix-logwatch-1.36.12.tgz c5eda596bc3d142ff5cf6db7986e6459 postfix-logwatch-1.36.12.tgz.1 OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane: SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version Issues: 1. rpmlint says: postfix-logwatch.noarch: E: non-executable-script /etc/logwatch/scripts/services/postfix 0644 It's not clear to me if this does need to be executable, but if it was you could run it standalone, so that might be better? postfix-logwatch.noarch: W: conffile-without-noreplace-flag /etc/logwatch/scripts/services/postfix Should this have (noreplace) for upgrades to avoid messing up people's customizations? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review