https://bugzilla.redhat.com/show_bug.cgi?id=1878902 --- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Andy Mender from comment #1) > I don't have much experience with packaging Java stuff, but I see this has > been sitting around for a while so I want to help. Thank you, Andy! I appreciate that. Sorry for the delay replying to this. > The Java Packaging Guidelines mention also that a Requires on > javapackages-filesystem should be added: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Java/ > #_buildrequires_and_requires > > Requires: javapackages-filesystem Right, it should have been javapackages-filesystem instead of javapackages-tools. Fixed. > The guidelines mention that the %{name}-javadoc subpackage should be > explicitly declared as noarch: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Java/ > #_javadoc_installation The wording is a bit unclear there. It means that if the main package is architecture-specific, then the javadoc package must explicitly be marked as noarch. In the case where the main package is noarch, all subpackages are implicitly noarch. Either way, you get a noarch javadoc package. > No %license file added to the package and I see neither the old nor the new > upstream have a license file in their source tree. Also, only the old > upstream mentions that the license is MIT. Could you ask upstream to add a > license file for the MIT license? Well, I can ask. The last upstream activity was 5 1/2 years ago, so I'm not optimistic about the result. In any case, all of the *.java files carry the full license at the top. > Also, a very minor thing, but you can use %{name} instead of "naga" :). "naga" is 4 character; "%{name}" is 7 :-). I do use %{name} where it refers to the package. I don't when referring to specific filenames. New URLs: Spec URL: https://jjames.fedorapeople.org/naga/naga.spec SRPM URL: https://jjames.fedorapeople.org/naga/naga-3.0-16.20150330git054a930.fc34.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
