https://bugzilla.redhat.com/show_bug.cgi?id=1881782 Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx --- Comment #2 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- >Spec URL: https://github.com/yunyings/accel-config/blob/master/accel-config.spec This link leads to a syntax-highlighted HTML rendition of the file. Please use "raw file" links to the spec. >Group: System Environment/Base >Group: Development/Libraries >Group: System Environment/Libraries >Group: Unspecified Not used in Fedora. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections >URL: https://github.com/intel/%{project_name} >Source0: https://github.com/intel/%{project_name}/archive/%{name}-v%{version}.tar.gz You can simplify Source0 by using replacing the beginning with the "%{URL}" macro. >make %{?_smp_mflags} Use %make_build instead. >%package -n %{name}-test >Summary: Unit tests for %{name}. Hm, I don't quite get this. Would a developer using accel-config-devel ever need to run these tests manually? Because "unit tests" makes it sound like they just test if the library has been built properly - in which case, the subpackage can be scrapped in favour of just running the test suite during the RPM build, in the %check section. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
