[Bug 1881381] Review Request: dtkgui - Deepin dtkgui

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1881381



--- Comment #2 from Robin Lee <robinlee.sysu@xxxxxxxxx> ---
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/cheeselee/deepin-packit-testing/fedora-rawhide-x86_64/01681792-dtkgui/dtkgui.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/cheeselee/deepin-packit-testing/fedora-rawhide-x86_64/01681792-dtkgui/dtkgui-5.2.2.15-2.fc34.src.rpm

(In reply to Andy Mender from comment #1)
> Koji build from mentioned side tag:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=52041656
> 
> > Name:           dtkgui
> > Version: 5.2.2.15
> > Release:        1%{?dist}
> > Summary:        Deepin dtkgui
> > License:        LGPLv3+
> > URL:            https://github.com/linuxdeepin/dtkgui
> 
> Could you align the Version field like the other fields?
Fixed.
> 
> > # no-op since Fedora 28
> > %ldconfig_scriptlets
> 
> This can/should be removed per
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/
> #_linker_configuration_files
Removed.
> 
> > %changelog
> > * Thu Jun 09 2020 uoser <uoser@xxxxxxxxxxxxx> - 5.2.2.1-1
> > - Update to 5.2.2.1
> 
> The %changelog entry is incorrect. June 9th was a Tuesday.
Fixed.
> 
> [!]: Package requires other packages for directories it uses.
>      Note: No known owner of /usr/libexec/dtk5
>      Review: Which packages provides this directory? dtkcore?
> [!]: Package must own all directories that it creates.
>      Note: Directories without known owners: /etc/dbus-1/system.d,
>      /usr/libexec/dtk5, /etc/dbus-1
>      Review: As above. Where applicable, either add missing Requires 
>      or make your package own the directories.
Will let dtkcore own /usr/libexec/dtk5.

> ===== EXTRA items =====
> 
> Generic:
> [!]: Rpmlint is run on all installed packages.
>      Note: Mock build failed
>      See: https://docs.fedoraproject.org/en-US/packaging-
>      guidelines/#_use_rpmlint
Only installable with dtkcore from the side tag.
> Source checksums
> ----------------
> https://github.com/linuxdeepin/dtkgui/archive/5.2.2.15/dtkgui-5.2.2.15.tar.
> gz :
>   CHECKSUM(SHA256) this package     :
> 59d65f9596077b8c5f3bbd603797197dab7b6b6b331ba197e6a060fd5301211d
>   CHECKSUM(SHA256) upstream package :
> 7f6bccc6807a15525ba9bebc308c2f7ead8e4aa11864fd7a67fd66bf954b61de
> diff -r also reports differences
Re-downloaded.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux