https://bugzilla.redhat.com/show_bug.cgi?id=1880711 --- Comment #3 from marcdeop@xxxxxxxxxxxxxxxxx --- (In reply to Jan Grulich from comment #2) > (In reply to marcdeop from comment #1) > > Is there a reason to create a new variable `%global base_name > > plasma-disks` when the value is the same as `Name`? > > It is kind of useless in this case, but we have been using this across all > Plasma components, because in certain cases the tarball name doesn't match > the package name. I kept it here for consistency. I don't mean to be offensive and maybe I am being pedantic but: wouldn't it make sense then to always use the `base_name` variable instead of sometimes `name` and sometimes `base_name`? For instance, from your spec: ``` %find_lang %{name} --all-name %files -f %{name}.lang ``` but: ``` %autosetup -n %{base_name}-%{version} -p1 Source0: http://download.kde.org/%{stable}/plasma/%{version}/%{base_name}-%{version}.tar.xz URL: https://invent.kde.org/plasma/%{base_name} ``` -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
