https://bugzilla.redhat.com/show_bug.cgi?id=1872427 Carl George 🤠 <carl@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carl@xxxxxxxxxx --- Comment #4 from Carl George 🤠 <carl@xxxxxxxxxx> --- Mohamed, are you taking over this package review submission from David? If so, please follow the same format as comment 0. fedora-review doesn't operate on attachments, and we'll need your FAS username when/if the package is approved. The information required is described in more detail in the wiki [0]. I manually took a look at your attachment, and there are still unresolved issues. The Group tag and %clean section must be removed [1]. The License identifier should be "ASL 2.0" [2]. All the files in `%{python3_sitelib}/ec2_hibinit_agent-%{version}-py3.*.egg-info` are owned, but that directory is not [3]. Since this requires acpid, there are several directories you don't need to own in %files (compare and remove the ones already owned by acpid). There are several improvements that could be made in the name of legibility [4]. - The %amzn macro is not allowed. - Between sections, this spec has double space, single space, and no space at all. Pick either double or single spacing and use it consistently. - The %setup macro by default expects %{name}-%{version}, so the -n flag is unnecessary. - Since you are setting the permissions on sleepconf and sleep.sh with install during %install, you don't need to set them again with %attr in %files. [0] https://fedoraproject.org/wiki/Package_Review_Process [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections [2] https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_valid_license_short_names [3] https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/#_wildcarding_files_inside_a_created_directory [4] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_spec_legibility -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
