https://bugzilla.redhat.com/show_bug.cgi?id=1879291 --- Comment #9 from Charalampos Stratakis <cstratak@xxxxxxxxxx> --- Thank you for the changes. That's a great licensing breakdown. Some more recommendations on that. I didn't go through the bundled code, however within https://github.com/bokeh/bokeh/blob/branch-2.3/bokehjs/LICENSE there is a breakdown of the licenses within the bundled software, so on the license field you'll need to add AFL and Unlicense and WTFPL (unless upstream has removed the software with those licenses and forgot to update the info). Also could you provide a comment in the SPEC for the parse-deps.py script on its purpose and usage? It can be obvious by reading the code, but an explanation comment would be quite useful. Also the shebang of the script should be changed to /usr/bin/python3 instead of the env variant. The rest look great. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
