https://bugzilla.redhat.com/show_bug.cgi?id=1878908 Steve Milner <smilner@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #3 from Steve Milner <smilner@xxxxxxxxxx> --- tl;dr: Some non-required SHOULDs are still outstanding but all MUSTs look covered. Update: + spec rpmlint rpmlint rust-bootupd.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. + source rpmlint rpmlint rust-bootupd-0.1.0-3.fc32.src.rpm rust-bootupd.src: W: spelling-error Summary(en_US) Bootloader -> Boot loader, Boot-loader, Boatload rust-bootupd.src: W: spelling-error %description -l en_US Bootloader -> Boot loader, Boot-loader, Boatload rust-bootupd.src: W: invalid-url URL: https://crates.io/crates/bootupd HTTP Error 404: Not Found 1 packages and 0 specfiles checked; 0 errors, 3 warnings. Clicking the link does show it's not a 404. + rpm rpmlint rpmlint /root/rpmbuild/RPMS/x86_64/bootupd-0.1.0-3.fc32.x86_64.rpm warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. bootupd.x86_64: W: spelling-error Summary(en_US) Bootloader -> Boot loader, Boot-loader, Boatload bootupd.x86_64: W: spelling-error %description -l en_US Bootloader -> Boot loader, Boot-loader, Boatload bootupd.x86_64: W: invalid-url URL: https://crates.io/crates/bootupd HTTP Error 404: Not Found bootupd.x86_64: W: empty-%postun 1 packages and 0 specfiles checked; 0 errors, 4 warnings. Clicking the link does show it's not a 404. + sources match $ sha256sum rust-bootupd-0.1.0-3.fc32.src/bootupd-0.1.0.crate 4c90182e11829eae328c2914b50dc2d73cbbeb79e7e3ea559477acf8f1a93926 rust-bootupd-0.1.0-3.fc32.src/bootupd-0.1.0.crate $ curl -L -O https://crates.io/api/v1/crates/bootupd/0.1.0/download#/bootupd-0.1.0.crate % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 29649 100 29649 0 0 33201 0 --:--:-- --:--:-- --:--:-- 33201 $ sha256sum bootupd-0.1.0.crate 4c90182e11829eae328c2914b50dc2d73cbbeb79e7e3ea559477acf8f1a93926 bootupd-0.1.0.crate + Build dependencies listed in BuildRequires and %cargo_generate_buildrequires is in use. This means they are not explicitly listed in the spec since Cargo.toml is looked at. Considering this good because it's following the pattern which is provided by the documentation. + build-dependencies are not denoted in Cargo.toml, though dependencies are set and are required at build time (https://github.com/coreos/bootupd/blob/master/Cargo.toml#L15-L31) Considering this good because the results work as expected by noting the dependencies in Cargo.toml -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
