https://bugzilla.redhat.com/show_bug.cgi?id=1878908 Steve Milner <smilner@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |smilner@xxxxxxxxxx --- Comment #1 from Steve Milner <smilner@xxxxxxxxxx> --- First pass: Using https://docs.fedoraproject.org/en-US/packaging-guidelines/ReviewGuidelines/ ----- ? = not able to verify yet + = LGTM - = Did not pass ----- ? spec rpmlint Warning makes sense as the create is not released yet. rust-bootupd.spec: W: invalid-url Source0: https://crates.io/api/v1/crates/bootupd/0.1.0/download#/bootupd-0.1.0.crate HTTP Error 404: Not Found 0 packages and 1 specfiles checked; 0 errors, 1 warnings. ? source rpmlint rust-bootupd.src: W: spelling-error Summary(en_US) Bootloader -> Boot loader, Boot-loader, Boatload rust-bootupd.src: W: spelling-error %description -l en_US Bootloader -> Boot loader, Boot-loader, Boatload "Bootloader" is valid (Eg: GRUB stands for GRand Unified Bootloader). rust-bootupd.src: W: invalid-url URL: https://crates.io/crates/bootupd HTTP Error 404: Not Found rust-bootupd.src: W: invalid-url Source0: https://crates.io/api/v1/crates/bootupd/0.1.0/download#/bootupd-0.1.0.crate HTTP Error 404: Not Found Warning makes sense as the create is not released yet. ? rpm rpmlint bootupd.x86_64: W: spelling-error Summary(en_US) Bootloader -> Boot loader, Boot-loader, Boatload bootupd.x86_64: W: spelling-error %description -l en_US Bootloader -> Boot loader, Boot-loader, Boatload "Bootloader" is valid (Eg: GRUB stands for GRand Unified Bootloader). bootupd.x86_64: W: invalid-url URL: https://crates.io/crates/bootupd HTTP Error 404: Not Found Expected as the release has not occured yet. bootupd.x86_64: W: empty-%postun Uses a macro which expands to empty + Naming Rust is not called out directly in https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/. However https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/ does denote the use of `rust-` prefix. + Package matches spec name + License ASL 2.0 + Code License matches https://github.com/coreos/bootupd/blob/master/LICENSE + License included in %license + spec is in American English + spec is legible ? sources match (not released yet) + ExclusiveArch set as required + Locales handled properly (none in use) ? Build dependencies listed in BuildRequires and %cargo_generate_buildrequires is in use. This means they are not explicitly listed in the spec since Cargo.toml is looked at. + %doc has nothing which is required for the application to run + filenames are valid utf-8 + Does not require deprecated packages + System libraries are not bundled + Package is not relocatable + Package owns it's created directories + Permissions are sane $ rpm -qplv ~/rpmbuild/RPMS/x86_64/bootupd-0.1.0-3.fc32.x86_64.rpm drwxr-xr-x 2 root root 0 Sep 15 18:48 /usr/lib/.build-id drwxr-xr-x 2 root root 0 Sep 15 18:48 /usr/lib/.build-id/12 lrwxrwxrwx 1 root root 31 Sep 15 18:48 /usr/lib/.build-id/12/2d5ba52019605d94ffab884b2f35d10dcd3dd6 -> ../../../../usr/libexec/bootupd -rw-r--r-- 1 root root 105 Sep 15 18:48 /usr/lib/systemd/system/bootupd.service -rw-r--r-- 1 root root 101 Sep 15 18:48 /usr/lib/systemd/system/bootupd.socket -rwxr-xr-x 1 root root 1311720 Sep 15 18:48 /usr/libexec/bootupd drwxr-xr-x 2 root root 0 Sep 15 18:48 /usr/share/doc/bootupd -rw-r--r-- 1 root root 2786 Sep 9 18:57 /usr/share/doc/bootupd/README.md drwxr-xr-x 2 root root 0 Sep 15 18:48 /usr/share/licenses/bootupd -rw-r--r-- 1 root root 11358 Jul 18 15:39 /usr/share/licenses/bootupd/LICENSE + No files listed more than once in %files + Macro use is consistent + Package contains code + No large docs requiring a -doc sub package + Not a static package/binary + No devel package produced + No .la archives + Not a GUI application SHOULDS: + Package builds on x86_64 + Package results execute as expected - (Not required) SHOULD: your package should contain man pages Continuing with https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/ + Is named rust-%{crate} + Uses BuildRequires: rust-packaging ? build-dependencies are not denoted in Cargo.toml, though dependencies are set and are required at build time (https://github.com/coreos/bootupd/blob/master/Cargo.toml#L15-L31) + Package explicitly sets arch to x86_64 so %{rust_arches} is not needed + %cargo_prep is used + crates are versioned and the tool is explicitly written to target Fedora/RHEL based systems SHOULDS: + scriptlets are mainly macros and seem sane - (not required) SHOULD: your package should contain man pages for binaries/scripts. If it doesn’t, work with upstream to add them where they make sense -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
