https://bugzilla.redhat.com/show_bug.cgi?id=1878529 Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #2 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- >Source2: https://raw.githubusercontent.com/Tomas-M/iotop/master/debian/upstream/signing-key.asc Shouldn't this also come from the version-tag, instead of master branch? What if the key is changed in master? >%install >rm -rf $RPM_BUILD_ROOT Don't remove the buildroot at start of %install. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections >%files >/usr/sbin/iotop >/usr/share/man/man8/iotop.8.gz 1. Don't use hard-coded paths here. Instead, use the appropriate RPM macros as described here: https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/#_macros_for_paths_set_and_used_by_build_systems 2. Don't assume that man pages will be gzipped. Use a wildcard that can match any compression method (including no compression at all). https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
