https://bugzilla.redhat.com/show_bug.cgi?id=1878806 --- Comment #5 from Stephen Kitt <skitt@xxxxxxxxxx> --- (In reply to Miguel Angel Ajo from comment #4) > another question, BuildRequires: git-core > > > Shouldint this be a Requires/too?, isn't it necessary for running and not > for building? Indeed, the shell/git module is supposed to check for git so it doesn’t end up being required for all sub-commands AFAICT, but in practice that doesn’t work: Traceback (most recent call last): File "/usr/local/bin/gitlint", line 5, in <module> from gitlint.cli import cli File "/usr/local/lib/python3.8/site-packages/gitlint/cli.py", line 20, in <module> from gitlint.git import GitContext, GitContextError, git_version File "/usr/local/lib/python3.8/site-packages/gitlint/git.py", line 4, in <module> from gitlint import shell as sh File "/usr/local/lib/python3.8/site-packages/gitlint/shell.py", line 13, in <module> from sh import git # pylint: disable=unused-import,import-error ImportError: cannot import name 'git' from 'sh' (/usr/local/lib/python3.8/site-packages/sh.py) Fixed in the spec. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
