Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ltsp-server - LTSP5 server-side configurations and setup scripts https://bugzilla.redhat.com/show_bug.cgi?id=331731 ------- Additional Comments From pertusus@xxxxxxx 2007-11-01 19:20 EST ------- (In reply to comment #67) > I think the reason it is implemented as a service is because it loses setuid > every time the fuse package is upgraded. Ultimately, this sucks and we need a > cleaner way to do this. I can't see why the fact that it should be run upon some event means that this should be a service. On linux, we try not to solve the problems by rebooting ;-). In any case is having the fuse mounts insecure a requirement for ltsp? It doesn't seems so to me. > I somewhat agree with removing those dependencies... although there is some > attractiveness of installing one package that pulls in everything people > typically use. Perhaps we could instead rely upon a yum group and comps. This shouldn't be the main ltsp-server in any case. A meta-package could be done, but it has to be separate (even if it is defined in the ltsp-server spec). It would be nice to have, for each script in /usr/share/ltsp5/scripts.d a comment at the beginning explaining what the script does. For example it is not clear to me what does: 07-xinetd-sysconfig-update I have spotted an error in 10-runlevel-hack: /usr/X11R6/bin/X should be /usr/bin/X In 15-kwin-update, it looks like to me that /usr/share/config/kwinrc is now /usr/share/kde-settings/kde-profile/default/share/config/kwinrc in 14-kdmrc-update the comment seems to be wrong. Also the code # add ICEwm to the session list if ($_ =~ /^SessionTypes=/i && $_ !~ /icewm/ ) { s/$/,icewm/; } seems to be obsolete. I also think that the performance tuning shouldn't be done in the default case, that is 15-kwin-update shouldn't be run, and in 14-kdmrc-update the following shouldn't be done in the default case: # turn off the clock if ($_ =~ /^LogoArea=Clock/ ) { $_ = "#" . $_ ; } -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review