[Bug 1877399] Review Request: power-profiles-daemon - Makes power profiles handling available over D-Bus

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1877399



--- Comment #3 from Bastien Nocera <bnocera@xxxxxxxxxx> ---
(In reply to Robert-André Mauchin 🐧 from comment #2)
>  - You must either link to a URL, or describe how you generated the archive
> in a comment (or provides a script that generate the archive):
> 
> Source0:        %{name}-%{version}.tar.xz

Fixed.

>  - %{?systemd_requires} → BuildRequires:  systemd-rpm-macros

Fixed.

>  - Fix the changelog entry :
> 
> power-profiles-daemon.x86_64: W: incoherent-version-in-changelog 0.0-1
> ['0.1-1.fc34', '0.1-1']
> 
> * Fri Aug 07 2020 Bastien Nocera <bnocera@xxxxxxxxxx> - 0.1-1

Fixed that too.

>  - Shouldn't this file be marked as %config(noreplace)? Could it be edited
> by the end user?
> 
> power-profiles-daemon.x86_64: W: non-conffile-in-etc
> /etc/dbus-1/system.d/net.hadess.PowerProfiles.conf

No, those aren't user-editable but are still in /etc...

> Package approved, please fix the aforementioned issue before import.

Thanks!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux