[Bug 1877702] Review Request: revelation - Password manager for the GNOME desktop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1877702

Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora@xxxxxxxxxx
           Doc Type|---                         |If docs needed, set a value



--- Comment #1 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> ---
>Summary:        Revelation is a password manager for the GNOME desktop.
No period at the end, please.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections

>License:        GPL-2.0
Use the "GPLv2" short identifier.
https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses

>%install
>rm -rf $RPM_BUILD_ROOT
Don't do this.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections

>%files
>%{_datadir}/metainfo/*.appdata.xml
>%{_datadir}/applications/*.desktop
You should add a BuildRequires: for "desktop-file-utils" and
"libappstream-glib" and then validate the desktop entry and AppStream file,
either at end of %install or in %check:
$ appstream-util validate-relax --nonet $PATH_TO_FILE
$ desktop-file-validate $PATH_TO_FILE
https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux