[Bug 1875997] Review Request: python-jsons - Python library for (de)serializing objects to/from JSON

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1875997



--- Comment #4 from Andy Mender <andymenderunix@xxxxxxxxx> ---
> Added

Thumbs up!

Honestly, I'm not quite sure how to proceed with this, however. I rebuilt the
package in COPR again:
https://copr.fedorainfracloud.org/coprs/andymenderunix/metrics2mqtt-and-dependencies/build/1654723/
Have a look at the logs specifically.

The reason why the build fails on Fedora 32 is because one of the tests shows
lower than expected performance:
https://github.com/ramonhagenaars/jsons/blob/master/tests/test_performance.py#L44
Below an example on aarch64. It's a lot worse on s390 (94.922601 seconds) and
armhfp (78.928779 seconds). Out of these aarch64, armhfp and x86_64 are
relevant.
> =================================== FAILURES ===================================
> __________________________ TestPerformance.test_dump ___________________________
> self = <tests.test_performance.TestPerformance testMethod=test_dump>
>     def test_dump(self):
> >       self._do_test_dump(16)
> tests/test_performance.py:45: 
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
> tests/test_performance.py:67: in _do_test_dump
>     self.assertTrue(delta_sec3 < time_limit, 'The operation took {} seconds'.format(delta_sec3))
> E   AssertionError: False is not true : The operation took 16.243726 seconds

I'm pretty sure we could argue with upstream to up the number here, since it's
arbitrary anyway. Still, the differences in timings are huge.

Fedora 33 and Rawhide have bigger problems due to the switch to Python 3.9.
Either the test cases need to be revisited or the code they cover. I can have a
look over the weekend to maybe file some PRs, but no earlier.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux