https://bugzilla.redhat.com/show_bug.cgi?id=1816301 --- Comment #20 from mark.olesen@xxxxxxxxxxxxx --- Hi Dave, (In reply to Dave Love from comment #19) > I'll comment as I'd previously packaged openfoam and started on making it > comply with Fedora-isms. > > The approach of putting it in its own tree (under %_libdir) is appropriate, > and it isn't a special case in that respect, but I can't see where it > actually goes now -- %prefix doesn't seem to be defined. An earlier comment stated that %prefix should not be defined (some policy). I had originally tried to make them relocatable, but that runs counter to what we now have. > I would expect the > source under /usr/src, but I don't know if there's policy on that. Generally true, but the structure of OpenFOAM expects its source under the project-directory. If we put it elsewhere, we would need to patch OpenFOAM like mad and do lots of tests to see that we haven't broken anything. For what it's worth, I've at least split off into proper sub-packages to avoid installing sources unless a '-devel' package is selected. > However, the packaging isn't at all right yet. I haven't checked in detail, > but I noticed: Fedora doesn't allow conditionals for other distributions > (which I think is unfortunate), Some sed'ing will work there, but it does seem a bit unfortunate. > you need serial and openblas and mpich > packages (unless mpich won't work for some reason), Doing a proper multibuild (serial and various MPI flavours) is still work-in-progress. I have a proof of concept for adding in additional MPI layers https://build.opensuse.org/package/show/home:openfoam/openfoam2006mpi but still haven't worked out a good way to manage the resulting configurations. If we actually need to get multi-build working for this to be a Fedora package, I fear that we will never get finished. /mark -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
