https://bugzilla.redhat.com/show_bug.cgi?id=1876864 --- Comment #2 from markusN <neteler@xxxxxxxxx> --- Thanks for your review, Artur. (In reply to Artur Frenszek-Iwicki from comment #1) > >Group: Sciences/Geosciences > Not used in Fedora. > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections removed. > >%description > >KEALib is a project to provide an implementation of the GDAL specification within the the HDF5 file format. Specifically, the format will support... > Whoa. The description should be wrapped so that all lines are 80 characters > max. > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > #_summary_and_description shunk and line wrapping fixed. > >mkdir -p %{_target_platform} > >pushd %{_target_platform} > Not needed. CMake out-of-source builds are now the default. removed. > >%cmake \ > > -DLIBDIR:PATH=/usr/lib64 \ > > -DGDAL_LIB_PATH:PATH=/usr/lib64 \ > Fedora still builds packages for some 32-bit architectures (i686 and > armv7hl, to be precise) - use "%{_libdir}" here. removed as being ignored anyway by KEA. > >make %{?_smp_mflags} -C %{_target_platform} > Use "%cmake_build" instead. > https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/ updated. > >make DESTDIR=%{buildroot} install > Try "%cmake_install" instead. updated. > >mkdir -p %{buildroot}%{_libdir}/ %{buildroot}%{_libdir}/gdalplugins/ > >mv %{buildroot}%{_prefix}/lib/libkea* %{buildroot}%{_libdir}/ > >mv %{buildroot}%{_prefix}/lib/gdalplugins/* %{buildroot}%{_libdir}/gdalplugins/ > Add some check whether "%{_prefix}/lib" is different than "%{_libdir}" so > that this doesn't fail on 32-bit architectures. Alternatively, try patching > the CMakeLists. I tried both to no avail. I must admit that I am not really familiar with cmake. This trick is also ignored by KEA: # fix wrong lib entry sed -i 's+set (PROJECT_LIBRARY_DIR lib)+set (PROJECT_LIBRARY_DIR %{_lib})+g' %{_builddir}/%{name}-%{version}/CMakeLists.txt > >%files > >%{_libdir}/libkea.so* > >%{_includedir}/libkea > Un-versioned .so files and C/C++ headers should go in a -devel package. > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages fixed. Now it also builds on F33 and rawhide: https://copr.fedorainfracloud.org/coprs/neteler/kealib/build/1653821/ Updated SPEC file: https://data.neteler.org/tmp/kealib.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
