https://bugzilla.redhat.com/show_bug.cgi?id=1873199 --- Comment #9 from Kalev Lember <klember@xxxxxxxxxx> --- Nice, thanks for the fixes! I'll let Andy do the final pass but looking good to me :) Just a few more remarks below: (In reply to Bastien Nocera from comment #8) > (In reply to Kalev Lember from comment #7) > > I don't think there's any requirement for shipping a docs within all > > subpackages. It's just dumb rpmlint warning about not having docs and that > > warning is fine to ignore. rpmlint output doesn't 100% match our packaging > > guidelines and best practices. > > > > What stand-alone subpackages need to have is a license file specified with > > %license (which they already have). > > > > > > I do have some other random comments here I noticed while going through the > > spec file: > > > > > > > Requires: gnome-user-docs > > > > Why is this hard dep necessary? It seems wrong from minimization point of > > view to drag in an unrelated docs package if one just wants to install the > > library. > > It was so that the /usr/share/help sub-directories were created. I've tried > to fix that up > in the latest version. Let me know if you wanted it done some other way, I > couldn't actually find examples in the checked out packages. Ahh, that's usually done with '%find_lang --with_gnome' which then picks up all the individual directories under /usr/share/help and adds the correct %files lang() attributes etc and writes it out to malcontent.lang, which you then include with %files -f malcontent.lang. I think the only missing part is adding --with-gnome to %find_lang and then you can drop the gnome-user-docs requires and all of the %{_datadir}/help references from %files. > > > %check > > > desktop-file-validate %{buildroot}%{_datadir}/applications/org.freedesktop.MalcontentControl.desktop > > > > It should also have appdata validation here. > > Done, but disabled for now: > https://gitlab.freedesktop.org/pwithnall/malcontent/-/issues/23 It should be validate-relax which should make it pass. appstream-util uses a bit weird naming there, but the idea was for 'validate' to mean "validate stuff that flathub wants" and 'validate-relax' to be "validate stuff that package-based distros want". > %files ui-libs > %license COPYING > %doc README.md > %{_libdir}/girepository-1.0/MalcontentUi-0.typelib This should have '%dir %{_libdir}/girepository-1.0' to own the directory as well. > %files libs > %license COPYING > %doc README.md > %{_libdir}/girepository-1.0/Malcontent-0.typelib ... and same here, '%dir %{_libdir}/girepository-1.0', which would then allow dropping 'Requires: gobject-introspection' from above. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
