https://bugzilla.redhat.com/show_bug.cgi?id=1873199 --- Comment #7 from Kalev Lember <klember@xxxxxxxxxx> --- I don't think there's any requirement for shipping a docs within all subpackages. It's just dumb rpmlint warning about not having docs and that warning is fine to ignore. rpmlint output doesn't 100% match our packaging guidelines and best practices. What stand-alone subpackages need to have is a license file specified with %license (which they already have). I do have some other random comments here I noticed while going through the spec file: > Requires: gnome-user-docs Why is this hard dep necessary? It seems wrong from minimization point of view to drag in an unrelated docs package if one just wants to install the library. > %package ui-devel > Summary: Development files for libmalcontent-ui > License: LGPLv2+ > Requires: %{name}-ui-libs%{?_isa} = %{version}-%{release} > Requires: pkgconfig(gtk+-3.0) I don't think you need to manually specify 'Requires: pkgconfig(gtk+-3.0)' as it's normally automatically generated based on the .pc file. If that doesn't happen, it's probably a bug in the .pc file. > Requires: gobject-introspection-devel Instead of this, please just use multiple directory ownership for the gir directories as we do in other gnome packages instead of hard-depending on gobject-introspection-devel. > %package ui-libs > Summary: Libraries for %{name} > License: LGPLv2+ > Requires: gobject-introspection Same thing here, please just use multiple directory ownership for the gir directories. I see that you are specifying "License: LGPLv2+" in all subpackages. This is fine, but unnecessary: it's enough to just specify it for the main package and then all subpackages inheriy the license tag of the main packages. > %check > desktop-file-validate %{buildroot}%{_datadir}/applications/org.freedesktop.MalcontentControl.desktop It should also have appdata validation here. > %ldconfig_scriptlets libs > %ldconfig_scriptlets ui-libs These are not needed in current Fedora versions and can just go (they evaluate to nothing). We have ldconfig triggers in place that automatically rebuild the ldconfig cache. > %{_mandir}/man8/malcontent-client.8.gz Can you use malcontent-client.8* glob here? This works better for flatpak builds that don't currently have man page compression applied. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
