https://bugzilla.redhat.com/show_bug.cgi?id=1860647 --- Comment #2 from Ding-Yi Chen <dchen@xxxxxxxxxx> --- Spec URL: https://dchen.fedorapeople.org/files/rpms/hexchat-autoaway.spec SRPM URL: https://dchen.fedorapeople.org/files/rpms/hexchat-autoaway-2.0-2.el8.src.rpm - Consider giving a more explicit name to your patch (by appending #/name-of-the-patch.patch for example) - Consider adding a comment above the patch to explain what it is doing. The patch is generated by GitHub pull request. Thus the filename is <pull-request-id>.patch To make up for it, I put the summary of the patch as comment in spec. - Please use the new CMake out of source building: https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds So far, my EL8 box does not have all the macros. I have to use: %{?!_vpath_builddir:%define _vpath_builddir %{_target_platform}} and mkdir -p %_vpath_builddir - (Use cmake3 if you want EPEL7 compatibility, otherwise just use %cmake) Done - Add an explicit BR for cmake Done - Add an explicit BR for gcc-c++ Done - Don't mix tabs and spaces: Fixed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
