https://bugzilla.redhat.com/show_bug.cgi?id=1873199 --- Comment #5 from Bastien Nocera <bnocera@xxxxxxxxxx> --- (In reply to Andy Mender from comment #4) > > I've added a desktop-file-validate in %check, is that enough? > > Yup, that should be enough according to the packaging guidelines. > > > [ ]: Package must own all directories that it creates. > > Note: Directories without known owners: /usr/share/help/C, > > /usr/share/gir-1.0, /usr/share/polkit-1/actions, > > /usr/share/accountsservice, /usr/share/help/id, > > /usr/share/polkit-1/rules.d, /usr/share/help/pt_BR, > > /usr/share/polkit-1, /usr/share/help/uk, /usr/share/dbus-1, > > /usr/share/help/pl, /usr/lib64/girepository-1.0 > > These directories still require proper ownership. Either you make the > subpackages which use them own them or add Requires lines for packages which > provide them. For instance, /usr/share/polkit-1 is provided by meson or > polkit, but I'd recommend polkit in this case. Check which directory is > provided by what with "dnf provides <path>". Will require: accountsservice-0.6.55-5 All the /usr/share/help/*/ directories should be owned by filesystem, because there's no way that gnome-user-docs will be able to own all the same dirs random packages could own, so it'll be filesystem's job to do that. I believe the rest is now fixed. > A couple of extra things picked up by rpmlint: > > malcontent-pam.x86_64: W: no-documentation > > malcontent-ui-devel.x86_64: W: no-documentation > > malcontent-devel.x86_64: W: no-documentation > > Since these are stand-alone subpackages, each needs its own %doc entry with > the README.md file. What does "stand-alone subpackages" actually mean? All those depend on packages from the same SRPM which contain the README, and if those are considered "stand-alone" despite having deps on other RPMs from the same source, what's considered "non stand-alone"? I haven't made any changes here. > > malcontent-ui-devel.x86_64: E: description-line-too-long C This package contains the pkg-config file and development headers for libmalcontent-ui. > > %description lines are 80 characters max. Either split it into multiple > lines or change it to something like "Contains the pkg-config file and > development headers for libmalcontent-ui." Done. Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=50755715 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
