https://bugzilla.redhat.com/show_bug.cgi?id=1875726 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- - Please do not gzip the manpages yourself, the compression is handled by rpm # for compressing man page BuildRequires: gzip […] %{_bindir}/gzip <ipp-usb.8 > %{buildroot}%{_mandir}/man8/ipp-usb.8.gz - Please glob the man page extension as the compression may change in the future: %{_mandir}/man8/ipp-usb.8.* - You install a systemd service, please add the required scriptlets: BuildRequires: systemd-rpm-macros […] %post %systemd_post ipp-usb.service %preun %systemd_preun ipp-usb.service %postun %systemd_postun_with_restart ipp-usb.service - You also install the library files (%gopkg/%gopkginstall/%gopkgfiles). If this library is used by another project to build stuff, would they also need pkgconfig(libusb-1.0) >= 1.0 and pkgconfig(avahi-client) >= 0.7 to compile? If yes, please add a %godevelheader with those Requires: %global godevelheader %{expand: Requires: pkgconfig(avahi-client) >= 0.7 Requires: pkgconfig(libusb-1.0) >= 1.0 } - Shouldn't this config file be marked as %config(noreplace) %config(noreplace) %{_sysconfdir}/ipp-usb/ipp-usb.conf - Own %{_sysconfdir}/ipp-usb/ %dir %{_sysconfdir}/ipp-usb/ - Your summary is too long (over 80 characters). Consider switch it with the the description which is too short. Don't repeat the package name in the Summary. - Summary of the issues detected by fedora-review: Issues: ======= - systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in ipp-usb See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_scriptlets [!]: Package requires other packages for directories it uses. Note: No known owner of /etc/ipp-usb Rpmlint ------- Checking: ipp-usb-0.9.13-1.fc34.x86_64.rpm golang-github-openprinting-ipp-usb-devel-0.9.13-1.fc34.noarch.rpm golang-github-openprinting-ipp-usb-debugsource-0.9.13-1.fc34.x86_64.rpm golang-github-openprinting-ipp-usb-0.9.13-1.fc34.src.rpm ipp-usb.x86_64: E: summary-too-long C Ipp-usb is an application implementing IPP protocol for USB printers, which are capable of IPP-over-USB connection ipp-usb.x86_64: W: name-repeated-in-summary C Ipp-usb ipp-usb.x86_64: W: description-shorter-than-summary ipp-usb.x86_64: W: non-conffile-in-etc /etc/ipp-usb/ipp-usb.conf golang-github-openprinting-ipp-usb-devel.noarch: E: summary-too-long C Ipp-usb is an application implementing IPP protocol for USB printers, which are capable of IPP-over-USB connection golang-github-openprinting-ipp-usb-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/OpenPrinting/ipp-usb/.goipath golang-github-openprinting-ipp-usb-debugsource.x86_64: E: description-line-too-long C This package provides debug sources for package golang-github-openprinting-ipp-usb. 4 packages and 0 specfiles checked; 3 errors, 4 warnings. - License ok - Latest version packaged - Builds in mock - Conforms to Packaging Guidelines -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
