[Bug 1874286] Review Request: perl-Acme-Alien-DontPanic2 - Test module for Alien::Base + Alien::Build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1874286



--- Comment #6 from Petr Pisar <ppisar@xxxxxxxxxx> ---
(In reply to Petr Pisar from comment #1)
> If you build-require some Alien::Build plugins, please buil-require all of
> them:
> FIX: Build-require 'perl(Alien::Build::Plugin::PkgConfig)' (alienfile:3).
> FIX: Build-require 'perl(Alien::Build::Plugin::Download)' (alienfile:12).
> FIX: Build-require 'perl(Alien::Build::Plugin::Extract)' (alienfile:16).
> 
Those modules do not exist. There are perl(Alien::Build::Plugin::*::Negotiate)
modules instead. First Alien::Build->apply_plugin() attempts to load the
Negotiate modules, and then it tries the original name:

  if($name !~ /::/ && !$found)
  {
    foreach my $inc (@INC)
    { 
      # TODO: allow negotiators to work with @INC hooks
      next if ref $inc;
      my $file = Path::Tiny->new("$inc/Alien/Build/Plugin/$name/Negotiate.pm");
      if(-r $file)
      { 
        $class = "Alien::Build::Plugin::${name}::Negotiate";
        $pm    = "Alien/Build/Plugin/$name/Negotiate.pm";
        $found = 1;
        last;
      }
    }
  }

  unless($found)
  {
    $class = "Alien::Build::Plugin::$name";
    $pm    = "Alien/Build/Plugin/$name.pm";
    $pm    =~ s{::}{/}g;
  }

Perhaps perl-Alien-Module package could provide perl-Alien-Module(PkgConfig)
and then the alienfile users could require it. Or provide an artificial
perl(Alien::Build::Plugin::PkgConfig). perl-Alien-Module is becoming pretty big
with many dependencies, like cmake and libffi. Splitting it into many
plugin-specific subpackages could make the dependency tree smaller.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux