[Bug 1874679] Review Request: grammalecte - French grammar checker

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1874679



--- Comment #2 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> ---
Thanks for your comments.

Spec URL:
https://melmorabity.fedorapeople.org/packages/grammalecte/grammalecte.spec
SRPM URL:
https://melmorabity.fedorapeople.org/packages/grammalecte/grammalecte-1.12.2-1.fc32.src.rpm

(In reply to Robert-André Mauchin 🐧 from comment #1)
>  - Please also mention these licenses and add a comment explaining the
> license breakdown.
> 
> Mozilla Public License 2.0
> --------------------------
> grammalecte-1.12.0/gc_lang/fr/oxt/Dictionnaires/dictionaries/fr-classique.aff
> grammalecte-1.12.0/gc_lang/fr/oxt/Dictionnaires/dictionaries/fr-reforme1990.
> aff
> grammalecte-1.12.0/gc_lang/fr/oxt/Dictionnaires/dictionaries/fr-
> toutesvariantes.aff
> grammalecte-1.12.0/lexicons/French.lex
I updated the License tag to add MPLv2.0 license, as well as LGPLv2+ for
hyphenation rule+thesaurus files. I also added comments to clarify the license
BD.

> 
> SIL Open Font License 1.1
> -------------------------
> grammalecte-1.12.0/gc_lang/fr/webext/fonts/YanoneKaffeesatz-Bold.otf
> grammalecte-1.12.0/gc_lang/fr/webext/fonts/YanoneKaffeesatz-Light.otf
> grammalecte-1.12.0/gc_lang/fr/webext/fonts/YanoneKaffeesatz-Regular.otf
> grammalecte-1.12.0/gc_lang/fr/webext/fonts/YanoneKaffeesatz-Thin.otf
Those files are not packaged (they're part of the JS implementation of
Grammalecte for Firefox and Thunderbird extensions; I don't package them since
they require NodeJS resources, especially web-ext, not available on Fedora).

>  - Please add a short comment explaining why you need to disable debuginfo
LibreOffice doesn't provide an arch-independent extension directory for
non-binary extensions. I added a comment about it in the SPEC file


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux