https://bugzilla.redhat.com/show_bug.cgi?id=1857767 --- Comment #4 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- (In reply to Miro Hrončok from comment #1) > Spec sanity: > > %{?python_provide:%python_provide python3-%{pypi_name}} > > > This can be dropped if you target rawhide only (which you probably should > because Fedora 31 and 32 have python3-pyephem and his package would > conflict). Removed. > Consider adding obsoletes/provides for python3-pyephem. Added. But the obsolete uses <=, please switch to <. <= is a tad confusing wrt release (and works the same in this case). > PYTHONPATH=%{buildroot}%{python3_sitelib} pytest-%{python3_version} -v > tests > > This can be replaced with simpler: > > %pytest -v tests Used. > -k "not test_jpl.py" > > Please add a comment about why is this deselected. Consider using --ignore > on the file directly. Not added. > %ifnarch armv7hl i686 > > Why are all the tests skipped on 32bit? Plese add a comment that explains it > and execute at least some tests if possible. The entire ifnarch is gone, thanks. > %{python3_sitearch}/%{pypi_name}-%{version}-py%{python3_version}.egg-info > > Consider adding trailing slash to ensure this is a directory. Not added. When you response to my feedback with a new spec file, could you please actually say what was changed? Otherwise I need to backtrack your changes. Thank you. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
