https://bugzilla.redhat.com/show_bug.cgi?id=1874286 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- The URL and Source0 addresses are usable. Ok. TODO: Remove a trailing slash from the URL value. Source0 archive (SHA-256: eb15ac418262a05d824c23c365a3c61911ff16f1fd51964d13847317c6e2681c) is original. Ok. Summary verified from lib/Acme/Alien/DontPanic2.pm. Ok. FIX: The description talks about Alien::Build. Not about Acme::Alien::DontPanic2. Please use the second paragraph from the POD like this: This module is a toy module to test the efficacy of the Alien::Base system. License verified from: Build.PL, README, LICENSE, and lib/Acme/Alien/DontPanic2.pm. Ok. FIX: Build-require 'coreutils' (perl-Acme-Alien-DontPanic2.spec:61). FIX: Build-require 'base' (lib/Acme/Alien/DontPanic2.pm:5). FIX: Do not build-require 'perl(Sort::Versions)'. It's not used anywhere. If you build-require some Alien::Build plugins, please buil-require all of them: FIX: Build-require 'perl(Alien::Build::Plugin::PkgConfig)' (alienfile:3). FIX: Build-require 'perl(Alien::Build::Plugin::Download)' (alienfile:12). FIX: Build-require 'perl(Alien::Build::Plugin::Extract)' (alienfile:16). All tests pass. Ok. $ rpmlint perl-Acme-Alien-DontPanic2.spec ../SRPMS/perl-Acme-Alien-DontPanic2-2.290.1-1.fc34.src.rpm ../RPMS/x86_64/perl-Acme-Alien-DontPanic2-2.290.1-1.fc34.x86_64.rpm sh: /usr/bin/python2: No such file or directory 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/perl-Acme-Alien-DontPanic2-2.290.1-1.fc34.x86_64.rpm drwxr-xr-x 2 root root 0 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/Acme drwxr-xr-x 2 root root 0 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/Acme/Alien drwxr-xr-x 2 root root 0 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/Acme/Alien/DontPanic2 -rw-r--r-- 1 root root 1337 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/Acme/Alien/DontPanic2.pm drwxr-xr-x 2 root root 0 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/Acme/Alien/DontPanic2/Install -rw-r--r-- 1 root root 169 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/Acme/Alien/DontPanic2/Install/Files.pm drwxr-xr-x 2 root root 0 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/auto/Acme drwxr-xr-x 2 root root 0 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/auto/Acme/Alien drwxr-xr-x 2 root root 0 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/auto/Acme/Alien/DontPanic2 -rw-r--r-- 1 root root 65 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/auto/Acme/Alien/DontPanic2/DontPanic2.txt drwxr-xr-x 2 root root 0 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/auto/share drwxr-xr-x 2 root root 0 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/auto/share/dist drwxr-xr-x 2 root root 0 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/auto/share/dist/Acme-Alien-DontPanic2 drwxr-xr-x 2 root root 0 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/auto/share/dist/Acme-Alien-DontPanic2/_alien -rw-r--r-- 1 root root 664 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/auto/share/dist/Acme-Alien-DontPanic2/_alien/alien.json -rw-r--r-- 1 root root 879 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/auto/share/dist/Acme-Alien-DontPanic2/_alien/alienfile drwxr-xr-x 2 root root 0 Sep 1 16:05 /usr/share/doc/perl-Acme-Alien-DontPanic2 -rw-r--r-- 1 root root 1563 Aug 28 18:37 /usr/share/doc/perl-Acme-Alien-DontPanic2/Changes -rw-r--r-- 1 root root 1053 Aug 28 18:37 /usr/share/doc/perl-Acme-Alien-DontPanic2/README drwxr-xr-x 2 root root 0 Sep 1 16:05 /usr/share/licenses/perl-Acme-Alien-DontPanic2 -rw-r--r-- 1 root root 18352 Aug 28 18:37 /usr/share/licenses/perl-Acme-Alien-DontPanic2/LICENSE -rw-r--r-- 1 root root 2358 Sep 1 16:05 /usr/share/man/man3/Acme::Alien::DontPanic2.3pm.gz File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-Acme-Alien-DontPanic2-2.290.1-1.fc34.x86_64.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.32.0) 1 perl(Acme::Alien::DontPanic2) 1 perl(Alien::Base) >= 0.038 1 perl(base) 1 perl(strict) 1 perl(warnings) 1 pkgconfig(dontpanic) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/x86_64/perl-Acme-Alien-DontPanic2-2.290.1-1.fc34.x86_64.rpm | sort -f | uniq -c 1 perl(Acme::Alien::DontPanic2) = 2.2901 1 perl(Acme::Alien::DontPanic2::Install::Files) 1 perl-Acme-Alien-DontPanic2 = 2.290.1-1.fc34 1 perl-Acme-Alien-DontPanic2(x86-64) = 2.290.1-1.fc34 Binary provides are Ok. $ resolvedeps f34-build ../RPMS/x86_64/perl-Acme-Alien-DontPanic2-2.290.1-1.fc34.x86_64.rpm Binary dependencies are resolvable. Ok. The package build in Fedora 34 (https://koji.fedoraproject.org/koji/taskinfo?taskID=50569245). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the 'FIX' items, and consider fixing the 'TODO' item before buidling this packaage. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
