https://bugzilla.redhat.com/show_bug.cgi?id=1874412 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are usable. Ok. Source0 archive (SHA-256: 2d3ff090899f7ea348e616581508f692a664bca84ff1eb59e409c67f851a9db2) is original. Ok. Summary verified from lib/PDF/API2/XS.pm. Ok. Description verified from lib/PDF/API2/XS.pm. Ok. FIX: The license tag (LGPLv2+) not accurate. These files declare a license: lib/PDF/API2/XS.pm: LGPLv2+ LICENSE: LGPLv2 Makefile.PL: LGPLv2 README: LGPLv2 Thus the license tag should be 'LGPLv2+ and LGPLv2'. I believe it's a upstream's mistake <https://rt.cpan.org/Ticket/Display.html?id=133256>, but until clarified, please use the more complicated license tag. TODO: Build-require 'coreutils' (perl-PDF-API2-XS.spec:40). Test::Perl::Critic, and Test::Pod are not used. Ok. All tests pass. Ok. $ rpmlint perl-PDF-API2-XS.spec ../SRPMS/perl-PDF-API2-XS-1.001-1.fc34.src.rpm ../RPMS/x86_64/perl-PDF-API2-XS-* sh: /usr/bin/python2: No such file or directory 4 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/perl-PDF-API2-XS-1.001-1.fc34.x86_64.rpm drwxr-xr-x 2 root root 0 Sep 1 13:32 /usr/lib/.build-id drwxr-xr-x 2 root root 0 Sep 1 13:32 /usr/lib/.build-id/56 lrwxrwxrwx 1 root root 77 Sep 1 13:32 /usr/lib/.build-id/56/7b3010baf7fde1cec604803fbbf9caa104f307 -> ../../../../usr/lib64/perl5/vendor_perl/auto/PDF/API2/XS/ImagePNG/ImagePNG.so drwxr-xr-x 2 root root 0 Sep 1 13:32 /usr/lib64/perl5/vendor_perl/PDF drwxr-xr-x 2 root root 0 Sep 1 13:32 /usr/lib64/perl5/vendor_perl/PDF/API2 drwxr-xr-x 2 root root 0 Sep 1 13:32 /usr/lib64/perl5/vendor_perl/PDF/API2/XS -rw-r--r-- 1 root root 1012 Aug 31 17:39 /usr/lib64/perl5/vendor_perl/PDF/API2/XS.pm -rw-r--r-- 1 root root 216 Aug 31 17:39 /usr/lib64/perl5/vendor_perl/PDF/API2/XS/ImagePNG.pm drwxr-xr-x 2 root root 0 Sep 1 13:32 /usr/lib64/perl5/vendor_perl/auto/PDF drwxr-xr-x 2 root root 0 Sep 1 13:32 /usr/lib64/perl5/vendor_perl/auto/PDF/API2 drwxr-xr-x 2 root root 0 Sep 1 13:32 /usr/lib64/perl5/vendor_perl/auto/PDF/API2/XS drwxr-xr-x 2 root root 0 Sep 1 13:32 /usr/lib64/perl5/vendor_perl/auto/PDF/API2/XS/ImagePNG -rwxr-xr-x 1 root root 15264 Sep 1 13:32 /usr/lib64/perl5/vendor_perl/auto/PDF/API2/XS/ImagePNG/ImagePNG.so drwxr-xr-x 2 root root 0 Sep 1 13:32 /usr/share/doc/perl-PDF-API2-XS -rw-r--r-- 1 root root 252 Aug 31 17:39 /usr/share/doc/perl-PDF-API2-XS/Changes -rw-r--r-- 1 root root 372 Aug 31 17:39 /usr/share/doc/perl-PDF-API2-XS/README drwxr-xr-x 2 root root 0 Sep 1 13:32 /usr/share/licenses/perl-PDF-API2-XS -rw-r--r-- 1 root root 24656 Aug 31 17:39 /usr/share/licenses/perl-PDF-API2-XS/LICENSE -rw-r--r-- 1 root root 1588 Sep 1 13:32 /usr/share/man/man3/PDF::API2::XS.3pm.gz File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-PDF-API2-XS-1.001-1.fc34.x86_64.rpm | sort -f | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.14)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libperl.so.5.32()(64bit) 1 libpthread.so.0()(64bit) 1 perl(:MODULE_COMPAT_5.32.0) 1 perl(Exporter) 1 perl(strict) 1 perl(warnings) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -q --provides -p ../RPMS/x86_64/perl-PDF-API2-XS-1.001-1.fc34.x86_64.rpm | sort -f | uniq -c 1 perl(PDF::API2::XS) = 1.001 1 perl(PDF::API2::XS::ImagePNG) = 1.001 1 perl-PDF-API2-XS = 1.001-1.fc34 1 perl-PDF-API2-XS(x86-64) = 1.001-1.fc34 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-PDF-API2-XS-1.001-1.fc34.x86_64.rpm Binary dependencies are resolvable. Ok. The package builds in Fedora 34 (https://koji.fedoraproject.org/koji/taskinfo?taskID=50558120). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the 'FIX' item, consider fixing the 'TODO' item, and provide a new spec file. Resolution: NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
