https://bugzilla.redhat.com/show_bug.cgi?id=1874058 --- Comment #3 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- - BR systemd-rpm-macros - %{_exec_prefix}/lib/systemd/system/logid.service → %{_unitdir}/logid.service - Add the systemd scriptlets. See https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_systemd %post %systemd_post logid.service %preun %systemd_preun logid.service %postun %systemd_postun_with_restart logid.service - License: GPL v3 → License: GPLv3 - %{cmake} call should be at the beginning of %build, not in %prep - Use a more specific name for your archive. Also we usually work with tar.gz in Linux Source0: https://github.com/PixlOne/logiops/archive/v%{version}.zip → Source0: https://github.com/PixlOne/logiops/archive/v%{version}/%{name}-%{version}.tar.gz - Please add your email to your changelog entry: * Mon Aug 31 2020 Nicolas De Amicis <deamicis@xxxxxxxxxx> - 0.2.2-1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
