https://bugzilla.redhat.com/show_bug.cgi?id=1874274 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are usable. Ok. TODO: Remove the trailing slash form the URL value. Source0 archive (SHA-256: 9a64e5f23a8bc109393aaea5855df7a032eb054d241df2422211e2253d9028a5) is original. Ok. Summary verified from lib/Alien/Build/MB.pm. Ok. Description verified from lib/Alien/Build/MB.pm. Ok. License verified from README, Makefile.PL, LICENSE, and lib/Alien/Build/MB.pm. Ok. TODO: Constrain 'perl(Alien::Build) with '>= 1.14' (META.json:49). All tests pass. Ok. $ rpmlint perl-Alien-Build-MB.spec ../SRPMS/perl-Alien-Build-MB-0.07-1.fc34.src.rpm ../RPMS/noarch/perl-Alien-Build-MB-0.07-1.fc34.noarch.rpm sh: /usr/bin/python2: No such file or directory 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Alien-Build-MB-0.07-1.fc34.noarch.rpm drwxr-xr-x 2 root root 0 Sep 1 09:48 /usr/share/doc/perl-Alien-Build-MB -rw-r--r-- 1 root root 732 Feb 6 2020 /usr/share/doc/perl-Alien-Build-MB/Changes -rw-r--r-- 1 root root 2155 Feb 6 2020 /usr/share/doc/perl-Alien-Build-MB/README drwxr-xr-x 2 root root 0 Sep 1 09:48 /usr/share/licenses/perl-Alien-Build-MB -rw-r--r-- 1 root root 18349 Feb 6 2020 /usr/share/licenses/perl-Alien-Build-MB/LICENSE -rw-r--r-- 1 root root 2197 Sep 1 09:48 /usr/share/man/man3/Alien::Build::MB.3pm.gz drwxr-xr-x 2 root root 0 Sep 1 09:48 /usr/share/perl5/vendor_perl/Alien drwxr-xr-x 2 root root 0 Sep 1 09:48 /usr/share/perl5/vendor_perl/Alien/Build -rw-r--r-- 1 root root 6967 Feb 6 2020 /usr/share/perl5/vendor_perl/Alien/Build/MB.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Alien-Build-MB-0.07-1.fc34.noarch.rpm |sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.32.0) 1 perl(Alien::Build) 1 perl(base) 1 perl(Module::Build) 1 perl(Path::Tiny) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 TODO: Constrain 'perl(Alien::Build) with '>= 1.14' (META.json:49). $ rpm -q --provides -p ../RPMS/noarch/perl-Alien-Build-MB-0.07-1.fc34.noarch.rpm |sort -f | uniq -c 1 perl(Alien::Build::MB) = 0.07 1 perl-Alien-Build-MB = 0.07-1.fc34 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Alien-Build-MB-0.07-1.fc34.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in Fedora 34 (https://koji.fedoraproject.org/koji/taskinfo?taskID=50543199). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please consider fixing the 'TODO' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
