https://bugzilla.redhat.com/show_bug.cgi?id=1872867 --- Comment #6 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> --- Despite the CFLAGS/LDFLAGS problem mentioned in the previous comment, there are few more things: - Please make consistent use of the spaces and tabs. You used tabs as a separator for the "Name", "Version" and others tags, but spaces for the "Requires" and "BuildRequires". Please be consistent. This is not a blocker, but nice to have. - I think the systemd configuration file should be installed into the /etc/sysconfig, i.e. /etc/sysconfig/stalld (without the .conf), not to the /etc/systemd [1]. Also please change the unit file accordingly. - Please use just (this is to also get rid of the unowned /usr/share/stalld-1.0 directory): %doc README.md to install the README file to the right location (i.e. /usr/share/doc/stalld), the /usr/share/stalld-1.0 seems strange. In such case the README shouldn't be installed in the Makefile. You could also change the Makefile to use the DOCDIR variable and then change the spec: %install %make_install DOCDIR=%{buildroot}%{_docdir} %files %{_docdir}/README.md - Nice to have (not a blocker): consider adding license file to the upstream project and installing it in the spec by the %license tag, e.g.: %license LICENSE.txt - You needn't list manual pages as a doc, but this is not a blocker [2] [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/Systemd/#_environmentfiles_and_support_for_etcsysconfig_files [2] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
