https://bugzilla.redhat.com/show_bug.cgi?id=1157162 --- Comment #6 from Pete Walter <walter.pete@xxxxxxxxxx> --- Thanks for taking this review, Robert-André! I've hopefully fixed up all the issues you pointed out. "mycmake" define is a define, not a global because it's supposed to be local to the %build section. Spec URL: https://pwalter.fedorapeople.org/badvpn.spec SRPM URL: https://pwalter.fedorapeople.org/badvpn-1.999.130-1.fc33.src.rpm * Sat Aug 29 2020 Pete Walter <pwalter@xxxxxxxxxxxxxxxxx> - 1.999.130-1 - Update to 1.999.130 - Switch to new cmake macros - Switch to autosetup - Add gcc BuildRequires - Remove no longer needed buildroot cleaning in install section koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=50440205 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
