https://bugzilla.redhat.com/show_bug.cgi?id=1871171 Joel Savitz <joelsavitz@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mail@xxxxxxxxxxxx Flags| |needinfo?(mail@xxxxxxxxxxxx | |) | |needinfo?(mail@fabian-affol | |ter.ch) --- Comment #5 from Joel Savitz <joelsavitz@xxxxxxxxx> --- (In reply to Robert-André Mauchin 🐧 from comment #4) > >> - Don't mix tabs and spaces > > I'm not sure where I made this mistake. Did you spot this in the spec? The source files were linted with flake8 but I certainly may have missed something. > > > Yes in the SPEC, not the source code. There's a tab line 2: > > %global pypi_name RPi.GPIO2 Fixed. > > > - please rename you SPEC python-rpi-gpio2 and also rename this bug as well. Done. > > - fix the changelog entry to reflect the header: > > * Wed Aug 19 2020 Joel Savitz <joelsavitz@xxxxxxxxx> - 0.3.0-1.a3 Done. > > - Please include the name in your archive: > > Source0: > https://github.com/underground-software/%{pypi_name}/archive/v%{version}a3/ > %{pypi_name}-%{version}a3.tar.gz > Done. > > > I propose that python-rpi-gpio be dropped from Fedora as it is broken on the Raspberry Pi, its only use case. > > > Please discuss this with the current maintainers of RPi.GPIO before any > action. If they accept, and if the functionality are the same, add an > Obsoletes/Provides for the old package. > > > I won't approve the package until the name clash is resolved with the > maintainers of the v1. Ark them to comment in this bug if they're okay with > it. Will needinfo the maintainers. Kushal and Fabian, what do you think of my proposal to replace python-rpi-gpio with python-rpi-gpio2? Updated spec: https://raw.githubusercontent.com/underground-software/RPi.GPIO2/packaging2/packaging/python-rpi-gpio2.spec Updated koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=50339420 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
