https://bugzilla.redhat.com/show_bug.cgi?id=1873199 --- Comment #3 from Bastien Nocera <bnocera@xxxxxxxxxx> --- (In reply to Andy Mender from comment #2) > > URL: https://gitlab.freedesktop.org/pwithnall/malcontent/ > > Source0: https://gitlab.freedesktop.org/pwithnall/malcontent/-/archive/%{version}/%{name}-%{version}.tar.bz2 > > You can replace the URL part in Source0 with %{url} to make it a little > shorter and avoid duplication. Sure. > > %package ui-devel > > Summary: Development files for libmalcontent-ui > > License: LGPLv2+ > > Requires: %{name}-ui-libs%{?_isa} = %{version}-%{release} > > Requires: gtk3-devel > > gtk3 provides a pkgconfig file so you can use the "pkgconfig(gtk3)" syntax > in the last line. Done. > I see the project provides a README.md. Could you attach it to all of the > stand-alone packages? OK. > Main review below: > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > > > Issues: > ======= > - Package installs a %{name}.desktop using desktop-file-install or desktop- > file-validate if there is such a file. > Review: Yes, a desktop file is listed and should use either of the above. > %files control > %license COPYING > %{_bindir}/malcontent-control > %{_datadir}/applications/org.freedesktop.MalcontentControl.desktop I've added a desktop-file-validate in %check, is that enough? v2 is in the same place at: https://hadess.fedorapeople.org/malcontent/ Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=50316270 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
