https://bugzilla.redhat.com/show_bug.cgi?id=1873302 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #2 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- - Use a better name for your archive: Source0: https://github.com/chrislim2888/IP2Location-C-Library/archive/%{version}.tar.gz → Source0: https://github.com/chrislim2888/IP2Location-C-Library/archive/%{version}/%{name}-%{version}.tar.gz - Not needed: Group: System Environment/Libraries BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) Group: Development/C rm -rf %{buildroot} %post -p /sbin/ldconfig %postun -p /sbin/ldconfig %clean rm -rf %{buildroot} %defattr(644,root,root,755) %defattr(-,root,root) %attr(755,-,-) - autoreconf -fi → autoreconf -fiv - make %{?_smp_mflags} → make_build - make clean shouldn't be needed - make install DESTDIR=%{buildroot} → make_install - Be more specific: %{_includedir}/* - Licenses must be installed with %license in %files and INSTALL shouldn't be provided %doc AUTHORS ChangeLog README.md NEWS %license COPYING LICENSE.TXT - In order to avoid unintentional soname bump, we recommend not globbing the major soname version, be more specific instead: %{_libdir}/*.so* - Own %{_datadir}/%{name}/tools/ by removing the glob %{_datadir}/%{name}/tools/ - don't use cp but install -p: cp tools/download.pl %{buildroot}%{_datadir}/%{name}/tools → install -pm 0755 tools/download.pl %{buildroot}%{_datadir}/%{name}/tools -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
