[Bug 1873108] Review Request: gnome-tour - GNOME Tour and Greeter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1873108



--- Comment #4 from Kalev Lember <klember@xxxxxxxxxx> ---
(In reply to Artur Iwicki from comment #2)
> > %global debug_package %{nil}
> Why? Other rust-* packages ship binaries with debuginfo.

Hm. Good question -- I thought it was common to not ship debuginfo in rust
packages, especially since the example in
https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/ has '%global
debug_package %{nil}'. Do you have any ideas what's missing that the debuginfo
isn't generated? I am not familiar at all with rust packaging.


> >BuildRequires:  /usr/bin/appstream-util
> Use "libappstream-glib".
> >BuildRequires:  /usr/bin/desktop-file-validate
> Use "desktop-file-utils".

Thanks for the suggestion, but I prefer it the way it is. It's more explanatory
to explicitly list the binary we need.


> Also, you're missing "ExclusiveArch:  %{rust_arches}".

Yes, I didn't use that because the list is exactly the same as regular Fedora
arches. We want the package on all Fedora-supported arches as it's going to be
in the default Workstation install. I'll be sure to add it in the future if
it's needed to keep the package building, but in the mean time I'd like to not
have the ExclusiveArch to avoid surprises.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux