https://bugzilla.redhat.com/show_bug.cgi?id=1872713 Artur Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx --- Comment #1 from Artur Iwicki <fedora@xxxxxxxxxx> --- > Spec URL: https://gitlab.com/fedora-mobile/atinout/-/blob/master/atinout.spec This link leads to a syntax-highlighted HTML rendition of the spec. Please use "raw file" links. > Patch0: 0001-disable-fallthrough.patch Add a comment explaining what the patch does. >%autosetup -p1 -n atinout-%{version} %{name}-%{version} is the default value for -n, you can omit it. >%build >make all %{?_smp_mflags} 1. Use the %make_build macro. 2. Call the %set_build_flags macro before calling make. >%install >%makeinstall DESTDIR=$RPM_BUILD_ROOT The %makeinstall macro is deprecated. Consider using %make_install instead. >%clean >rm -rf $RPM_BUILD_ROOT Don't do this. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections >%files >%doc %{_mandir}/man1/atinout.1.gz 1. Man pages should not be marked as %doc. 2. Do not assume that man pages will be gzipped. Use a wildcard that can match any compression method (including no compression at all). https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages >%doc README atinout.1.html gplv3.txt logo/atinout.svg "gplv3.txt" should be marked as "%license", not "%doc". -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
