https://bugzilla.redhat.com/show_bug.cgi?id=1861887 --- Comment #4 from Jonny Heggheim <hegjon@xxxxxxxxx> --- (In reply to Robert-André Mauchin 🐧 from comment #3) > - %{__make} → make > > Variable starting with __ are for rpm private use. > > - Add a comment above the patch to explain what it does/why it is needed > > - Rename your patch to have a meaningful name > > Patch0: > https://patch-diff.githubusercontent.com/raw/facebook/rocksdb/pull/7187. > patch#/0001-your-fancy-name.patch > > Package approved, please fix the aforementioned issue before import. Thanks for the review, I will fix those issues before import. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
