[Bug 1854729] Review Request: nispor - API for network state query written in rust

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1854729

Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(zebob.m@xxxxxxxxx |
                   |)                           |



--- Comment #16 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> ---
 - Add comments explaining why patches are needed

Patch1:         0001-varlink-Upgrade-to-rust-varlink-11.patch
Patch2:         0002-Makefile-Better-handling-on-libdir.patch

 - Please justify why you disabled the tests:

%bcond_with check

 -

env SKIP_PYTHON_INSTALL=1 DESTDIR=%{buildroot} PREFIX=/usr \
    LIBDIR=%{_libdir} make install

→ 

env SKIP_PYTHON_INSTALL=1 PREFIX=%{_prefix} \
    LIBDIR=%{_libdir} %make_install

 - Add license in these packages as well

%files -n       python3-%{name}
%license LICENSE
%{python3_sitelib}/nispor*

%files -n       rust-%{name}-devel
%license LICENSE
%{cargo_registry}/%{name}-%{version_no_tilde}/

 - In order to avoid unintentional soname bump, we recommend not globbing the
major soname version:

%{_libdir}/libnispor.so.0*

 - Add arch specific info for your Requires

%package        devel
Summary:        %{summary}
Requires:       nispor%{?_isa} = %{?epoch:%{epoch}:}%{version}-%{release}

 -Error while installing

DEBUG util.py:621:   Problem: conflicting requests
DEBUG util.py:621:    - nothing provides libnispor.so()(64bit) needed by
nispor-devel-0.3.0-1.fc34.x86_64 

Not sure what's causing this:

rpm -q --provides -p nispor-devel-0.3.0-1.fc34.x86_64.rpm | sort -f | uniq -c  
                                                                    21:19:36
      1 nispor-devel = 0.3.0-1.fc34
      1 nispor-devel(x86-64) = 0.3.0-1.fc34

rpm -q --requires -p nispor-devel-0.3.0-1.fc34.x86_64.rpm | sort -f | uniq -c  
                                                                  21:20:01
      1 libnispor.so()(64bit)
      1 nispor(x86-64) = 0.3.0-1.fc34
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1

It seems to me the library is badly compiled as it doesn't have a soname:

objdump -p libnispor.so.0.3.0  | grep SONAME

Could be why it isn't requiring libnispor.so()(64bit) instead of
libnispor.so.0.3.0()(64bit)

 - libnispor.so.0.3.0 is not marked as 0755:

-rw-r--r--. 1 bob bob 14M Aug 25 21:16 libnispor.so.0.3.0

Use:

chmod 0755 %{buildroot}%{_libdir}/libnispor.so.0.3.0

in install, but or use the patch I sent upstream to fix the Makefile, line 87:

        install -v -D -m644 $(CLIB_SO_DEV_RELEASE) \
                $(DESTDIR)$(LIBDIR)/$(CLIB_SO_FULL)

Should be 0755: https://github.com/nispor/nispor/pull/13

On a side note this allow you to reenable the debuginfo, now that the library
is executable, debuginfo will be correctly generated.

 - Also you should fix the Makefile to use "install -p" for files to keep the
timestamps.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux