[Bug 1868992] Review Request: jakarta-server-pages - Jakarta Server Pages (JSP)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1868992



--- Comment #2 from Mat Booth <mat.booth@xxxxxxxxxx> ---
Issues:

1)

Hmm, just like jakarta-servlet package, half the source files have "ASL 2.0"
headers instead of the "EPL-2.0 or GPLv2", so I think the license field would
be more accurate as this:

ASL 2.0 and (EPL-2.0 or GPLv2 with exceptions)

I read the upstream bug you filed for servlet-api (
https://github.com/eclipse-ee4j/servlet-api/issues/347 ) and it seemed to take
them by surprise! So probably worth filing a bug upstream for this one too.


2)

For some boring technical reasons, Eclipse requires the JDTJavaCompiler adapter
implementation, which in the old package was enabled by this patch:

https://src.fedoraproject.org/rpms/glassfish-jsp/blob/84ff3bc904d196045bbbba9ec2d5140391847dd3/f/0001-Enable-Eclipse-JDT-compiler-support-for-runtime-JSP-.patch

This does not appear to have made the transition. The new package instead
deletes JDTJavaCompiler and removes the dep on ecj. Any chance this can be
restored?

I know it's a deviation from the upstream's distribution available from maven
central, but the Eclipse Foundation ships it's own build with this addition to
allow JSP to use Eclipse's built-in ECJ Java compiler for compiling JSP pages
at runtime.


3)

The "compat namespace" (cp -pr && sed s/javax/jakarta/) causes compilation
errors in Eclipse. The problem is due to mixed usage of javax.* and jakarta.*
classes when referencing classes directly from the implementation jar.

Eclipse does stuff like this example:

import javax.servlet.Servlet; // An API class
import org.apache.jasper.servlet.JspServlet; // An impl class

Servlet s = new JspServlet;

HOWEVER, JspServlet extends "jakarta.servlet.Servlet" and NOT
"javax.servlet.Servlet" which makes JspServlet unassignable to Servlet in this
context (type mismatch, compilation error)

So although this compat "hack" works fine when only the API classes are used
(javax.* classes) it fails when we try to use classes from the implementation
jar without fully migrating to jakarta.* APIs.

I need a bit of time to think about how best to solve this. It looks like we
only reference JSP implementation classes a couple times in Eclipse code, so
perhaps I will be able to come up with a concise patch there. Or do something
cleverer in this package and jakarta-servlet package. Hmmm....




For completion, the full review tool output follows below. FTR,
obsoletes/provides look fine to me, I don't know why the review tool does not
enumerate the obsoletes as it does with the provides...


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* Eclipse Public License
     2.0", "Eclipse Public License 2.0", "Apache License 2.0". 45 files
     have unknown license. Detailed output of licensecheck in
     /home/mbooth/fedora/1868992-jakarta-server-pages/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in jakarta-
     server-pages-api
[!]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Requires
--------
jakarta-server-pages (rpmlib, GLIBC filtered):
    java-headless
    javapackages-filesystem
    mvn(jakarta.el:jakarta.el-api)
    mvn(jakarta.servlet.jsp:jakarta.servlet.jsp-api)

jakarta-server-pages-api (rpmlib, GLIBC filtered):
    java-headless
    javapackages-filesystem

jakarta-server-pages-javadoc (rpmlib, GLIBC filtered):
    javapackages-filesystem


Provides
--------
jakarta-server-pages:
    glassfish-jsp
    jakarta-server-pages
    mvn(org.eclipse.jetty.orbit:org.apache.jasper.glassfish)
    mvn(org.eclipse.jetty.orbit:org.apache.jasper.glassfish:pom:)
    mvn(org.glassfish.web:jakarta.servlet.jsp)
    mvn(org.glassfish.web:jakarta.servlet.jsp:pom:)
    mvn(org.glassfish.web:javax.servlet.jsp)
    mvn(org.glassfish.web:javax.servlet.jsp:pom:)
    osgi(org.glassfish.web.jakarta.servlet.jsp)

jakarta-server-pages-api:
    glassfish-jsp-api
    jakarta-server-pages-api
    mvn(jakarta.servlet.jsp:jakarta.servlet.jsp-api)
    mvn(jakarta.servlet.jsp:jakarta.servlet.jsp-api:pom:)
    mvn(javax.servlet.jsp:javax.servlet.jsp-api)
    mvn(javax.servlet.jsp:javax.servlet.jsp-api:pom:)
    mvn(javax.servlet:jsp-api)
    mvn(javax.servlet:jsp-api:pom:)
    osgi(jakarta.servlet.jsp-api)

jakarta-server-pages-javadoc:
    glassfish-jsp-api-javadoc
    glassfish-jsp-javadoc
    jakarta-server-pages-javadoc



Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16
Command line :/usr/bin/fedora-review -b 1868992 -m fedora-33-x86_64 -o
--enablerepo local
Buildroot used: fedora-33-x86_64
Active plugins: Java, Generic, Shell-api
Disabled plugins: SugarActivity, R, fonts, Haskell, Ocaml, C/C++, PHP, Perl,
Python
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux